Conversation
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
Error is on gitter link. Should we remove this completely now that we are primarily on discourse?
This comment was marked as duplicate.
This comment was marked as duplicate.
I tried to fix it, but to no avail. Since it's so low traffic, I think 👍 for removing it, which I've done hte lastest commit. |
|
🎉 this is working now - @timhoffm do you want to do a check on the final state of this PR, then merge if it looks good? |
|
I've manually checked the diffs and they look fine/as expected. |
|
Can we download it off Google Fonts, like the others? We should be getting proper small-caps support in 3.11 (i.e., pick a font and toggle the OpenType feature if it supports it.) |
|
Google fonts only serves |
|
I'm also very up for replacing this with another font that supports small-caps, but I couldn't easily find another one. |
|
I didn't know about that from pathlib import Path
import matplotlib.pyplot as plt
font_path = Path.home() / 'Downloads/EBGaramond-VariableFont_wght.ttf'
fig = plt.figure(figsize=(7, 5))
fig.text(0.5, 0.90, 'Ligatures', font=font_path, fontsize=40,
horizontalalignment='center')
# Default has Standard Ligatures (liga).
fig.text(0, 0.78, 'Default: fi ffi fl st', font=font_path, fontsize=40)
# Disable Standard Ligatures with -liga.
fig.text(0, 0.67, 'Disabled: fi ffi fl st', font=font_path, fontsize=40,
fontfeatures=['-liga'])
# Enable Discretionary Ligatures with dlig.
fig.text(0, 0.56, 'Discretionary: fi ffi fl st', font=font_path, fontsize=40,
fontfeatures=['dlig'])
fig.text(0.5, 0.40, 'Capitals', font=font_path, fontsize=40,
horizontalalignment='center')
# Enable Small Capitals from Capitals.
fig.text(0, 0.28, 'SMALL CAPS FROM CAPS', font=font_path, fontsize=40,
fontfeatures=['c2sc'])
# Enable Small Caps.
fig.text(0, 0.16, 'Small Caps: AaBbCcDdEeFf', font=font_path, fontsize=40,
fontfeatures=['smcp'])
# Enable Petite Caps.
fig.text(0, 0.04, 'Petite Caps: AaBbCcDdEeFf', font=font_path, fontsize=40,
fontfeatures=['pcap'])
plt.show()
|
3 participants
For a while downloading the font for this example has been failing. I then realised that the code here isn't actually using Matplotlib to specifcially request a small caps font, it's just plotting in a font that is already small caps:
Some brief searching suggests small caps fonts are rare, and thus I think this is a niche enough case that dropping this is okay.